Conversation
mattnibs
force-pushed
the
mv-more-vam-tests
branch
from
692bc1d to
164b9f0
Compare
nwt
reviewed
Jan 16, 2026
Member
nwt
left a comment
nwt
left a comment
There was a problem hiding this comment.
I don't think you should move in-star.yaml or user-join.yaml since they aren't being enabled for vam as advertised in the PR title.
Collaborator
Author
|
@nwt they aren't enabled for any runtime! I just don't like have these tests in two places and am going to remove the folder |
Member
|
@mattnibs: runtime/ztests/expr/in-star.yaml would, if fixed, duplicate runtime/sam/expr/ztests/in-star.yaml so how about removing it instead of moving it. |
nwt
approved these changes
Jan 22, 2026
Member
nwt
left a comment
nwt
left a comment
There was a problem hiding this comment.
If you're going to include skipped tests in this, please at least add 'vector: true' to them.
Move and enable more tests that now work in the vector runtime.
mattnibs
force-pushed
the
mv-more-vam-tests
branch
from
164b9f0 to
f2e6afc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move and enable more tests that now work in the vector runtime.