Insert veneers on arm64 in cranelift-jit where necessary #12239
+252
−199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a wasmtime specific format that doesn't match what cranelift-jit could register with the system unwinder in the future.
bjorn3
force-pushed
the
cranelift_jit_fixes
branch
3 times, most recently
from
d3ab84d to
d4569d5
Compare
github-actions
bot
added
cranelift
fitzgen
approved these changes
Jan 5, 2026
Member
fitzgen
left a comment
fitzgen
left a comment
There was a problem hiding this comment.
LGTM! Just one tiny suggestion below.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
In preparation for inserting veneers on arm64.
bjorn3
force-pushed
the
cranelift_jit_fixes
branch
from
c6e831e to
6fb2a9d
Compare
Contributor
Author
|
Fixed the missing import on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with an incorrect assertion, the lack of this caused jumps to random memory locations if the target is too far away.
Fixes rust-lang/rustc_codegen_cranelift#1619