Deprecate SessionAuthenticator identify option #763
+77
−48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
identifyoption in SessionAuthenticatorWhy deprecate
identify?The
identifyoption only verifies that the username exists in the database - it does not verify passwords as the documentation previously suggested.When
identify => true:fieldsconfig only includesusername, so only the username is passed to the identifierPasswordIdentifier::identify()method skips password verification when no password credential is providedpasswordto fields, it fails because sessions store hashed passwords, butpassword_verify(hash, hash)doesn't workThis makes the option ineffective for:
Users should use
PrimaryKeySessionAuthenticatorinstead if they need to fetch fresh user data from the database on each request.Quick Start example improvement
The SessionAuthenticator doesn't need an identifier by default - it just uses session data directly as identity. The example was unnecessarily passing
$passwordIdentifierto it.