moved check for valid ipv4 as to not accept bogus address when matching /0 range #6015
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
Author
|
@cf-bottom Heyo, jenkins please? |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13314/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13314/ |
Contributor
|
Thanks! Please add to the commit message. You can use |
Changelog: Fixed bug where isipinsubnet() fails to validate bogus IPv4 addresses when checking the 0.0.0.0/0 range
SimonThalvorsen
force-pushed
the
CFE-3081
branch
from
5487343 to
10bca9d
Compare
olehermanse
requested changes
Jan 14, 2026
Member
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
@SimonThalvorsen The Ticket and Changelog parts Lars mentioned should be a kind of "footer", the commit should still have a good title (first line).
See here for more info and examples;
https://github.com/cfengine/core/blob/master/CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.