⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Jan 18, 2026

Description

Community localization improvements built on top of the ff. PRs:

Added PR authors as co-authors and switched base branch to core-2. I'll open another PR pointing to core-3/main.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2026

🦋 Changeset detected

Latest commit: be783d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jan 18, 2026 9:13pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

This pull request adds a changeset entry and updates localization files for @clerk/localizations. It modifies the import source for LocalizationResource from @clerk/types to @clerk/shared/types across three language modules (Greek, French, Korean), while simultaneously updating numerous translation strings for improved accuracy and consistency in each language.

Changes

Cohort / File(s) Summary
Changeset Entry
.changeset/afraid-plums-sing.md
New patch changeset documenting version bump and localization updates for el-GR, fr-FR, and ko-KR.
Localization Files
packages/localizations/src/el-GR.ts, packages/localizations/src/fr-FR.ts, packages/localizations/src/ko-KR.ts
Import path updated from @clerk/types to @clerk/shared/types for LocalizationResource type. Translation strings refined across all three files: el-GR and ko-KR include extensive new/updated translations; fr-FR includes grammar, wording, and formality improvements.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 Translations dance in threes,
From Greek to French with ease,
Korean whispers flow so bright,
Shared types now unite the light,
Words bloom in every locale's delight!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title accurately summarizes the main changes: improvements to French, Korean, and Greek translations across localization files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsoriano wobsoriano changed the base branch from main to release/core-2 January 18, 2026 20:55
@wobsoriano wobsoriano marked this pull request as ready for review January 18, 2026 20:55
@wobsoriano wobsoriano changed the title chore(translations): Update Greek translations chore(translations): Improved frech, korean and greek translations Jan 18, 2026
@wobsoriano wobsoriano changed the title chore(translations): Improved frech, korean and greek translations chore(localizations): Improved frech, korean and greek translations Jan 18, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 18, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7619

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7619

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7619

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7619

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7619

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7619

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7619

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7619

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7619

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7619

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7619

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7619

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7619

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7619

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7619

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7619

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7619

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7619

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7619

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7619

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7619

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7619

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7619

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7619

commit: be783d1

@wobsoriano wobsoriano changed the title chore(localizations): Improved frech, korean and greek translations chore(localizations): Improved french, korean and greek translations Jan 18, 2026
@wobsoriano
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 18, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@packages/localizations/src/el-GR.ts`:
- Line 25: The localization key createdAndExpirationStatus__expiresOn in
el-GR.ts uses the placeholder {{expirationDate}} which doesn't match the
canonical en-US template variable {{expiresDate}}; update the placeholder in
createdAndExpirationStatus__expiresOn from expirationDate to expiresDate so the
interpolation name matches the source template and placeholders render
correctly.

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants