[C#] Update module bindings to use new View ABI #4146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This change implements the module bindings changes to Views that where updated with core in #3685 and the Rust module bindings implementation in #3819.
Updates the C# module bindings to use new header-first view ABI (
ViewResultHeader) and updates the return codes for the__call_view__and__call_view_anon__module exports. This is a prerequsite forQuerybuilder support being added to C# modules.API and ABI breaking changes
Not breaking. Existing modules will continue to use the old ABI. New modules will use the new ABI. However previous host versions will not support modules built using this version of the bindings.
Expected complexity level and risk
2
Testing
This is an internal refactor. All existing tests should continue to pass. All existing tests should continue to pass. The only tests that needed updating were the C# codegen snapshot tests (
Codegen.Tests) because the generated view dispatcher bodies changed (they now prefixViewResultHeader.RowDatabefore the existing row payload).