⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@MungoG
Copy link
Contributor

@MungoG MungoG commented Jan 20, 2026

Summary by CodeRabbit

  • Chores

    • Updated ignore patterns to exclude new cache, tooling config, and temporary working-directory files; adjusted build preset path handling to reference repository root.
    • Expanded unit-test dependency set to include networking support, improving test coverage.
  • Chores / CI

    • Integrated an external coroutine-based component into CI and documentation workflows; added steps to fetch and include its artifacts during builds and scans.

✏️ Tip: You can customize this high-level summary in your review settings.

@MungoG MungoG marked this pull request as ready for review January 20, 2026 13:45
@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

📝 Walkthrough

Walkthrough

Adds new ignore entries to .gitignore; updates CMake test library list to include asio; and integrates the Corosio repository into CI workflows by cloning, patching into libs/corosio, and copying corosio artifacts into relevant jobs.

Changes

Cohort / File(s) Summary
Version Control
/.gitignore
Added ignore entries: .cache/, .clangd, and /tmpclaude-*-cwd; changed CMakeUserPresets.json reference to /CMakeUserPresets.json; retained existing build/out ignores and the !/build/Jamfile exception.
Build Configuration
CMakeLists.txt
In the block excluding BOOST_URL_MRDOCS_BUILD and BOOST_HTTP_BUILD_TESTS, BOOST_HTTP_UNIT_TEST_LIBRARIES now includes asio alongside filesystem.
CI / Automation
.github/workflows/ci.yml
Adds cloning of cppalliance/corosio, removes any preexisting corosio modules before patching, copies corosio-root into libs/corosio, updates module-scan ignores to include corosio, and copies corosio artifacts into PR and Antora/Changelog jobs.

Sequence Diagram(s)

sequenceDiagram
    participant CI as CI Workflow
    participant Repo as Source Repo
    participant Corosio as cppalliance/corosio
    participant Patch as Patch Step
    participant Build as Build Job

    CI->>Corosio: git clone corosio repo
    CI->>Repo: remove existing corosio module (if any)
    CI->>Patch: copy corosio-root -> libs/corosio
    Patch->>Repo: apply corosio files into boost-root
    CI->>Build: copy corosio artifacts into build workspace
    Build->>Corosio: build/tests include corosio sources
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~40 minutes

Poem

🐇 I hopped through git and hid a tidy trace,

Brought clangd and caches to a secret place,
I fetched a friend named Corosio to play,
Let asio join tests and romp all day,
A little rabbit's patch — neat tracks in code hay.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'cmake fix' is too vague and generic. While the PR does contain CMake-related changes (library updates in CMakeLists.txt), the changes also include .gitignore updates and significant CI workflow modifications involving corosio integration, making the title insufficiently specific. Use a more descriptive title that captures the primary changes, such as 'Add corosio dependency and update build configuration' or 'Integrate corosio library and update CI workflows'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://247.http.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-01-20 13:52:23 UTC

@cppalliance-bot
Copy link

GCOVR code coverage report https://247.http.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://247.http.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff https://247.http.prtest3.cppalliance.org/gcovr/coverage_diff.txt

Build time: 2026-01-20 14:07:34 UTC

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@CMakeLists.txt`:
- Around line 77-79: The CMake conditional uses the wrong variable name: change
the check from BOOST_URL_MRDOCS_BUILD to the intended BOOST_HTTP_MRDOCS_BUILD so
the block governed by the existing option behaves correctly; update the if
condition that currently reads NOT BOOST_URL_MRDOCS_BUILD to use NOT
BOOST_HTTP_MRDOCS_BUILD (the other symbols in the block are
BOOST_HTTP_BUILD_TESTS and BOOST_HTTP_UNIT_TEST_LIBRARIES).

Comment on lines 77 to +79
if (NOT BOOST_URL_MRDOCS_BUILD)
if (BOOST_HTTP_BUILD_TESTS)
set(BOOST_HTTP_UNIT_TEST_LIBRARIES filesystem)
set(BOOST_HTTP_UNIT_TEST_LIBRARIES asio filesystem)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Pre-existing issue: Variable name mismatch.

Line 77 checks BOOST_URL_MRDOCS_BUILD, but the option defined on line 40 is BOOST_HTTP_MRDOCS_BUILD. This means the condition NOT BOOST_URL_MRDOCS_BUILD will always evaluate to true (unless BOOST_URL_MRDOCS_BUILD is set externally), which may not be the intended behavior.

Suggested fix (outside the scope of this PR)
-if (NOT BOOST_URL_MRDOCS_BUILD)
+if (NOT BOOST_HTTP_MRDOCS_BUILD)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if (NOT BOOST_URL_MRDOCS_BUILD)
if (BOOST_HTTP_BUILD_TESTS)
set(BOOST_HTTP_UNIT_TEST_LIBRARIES filesystem)
set(BOOST_HTTP_UNIT_TEST_LIBRARIES asio filesystem)
if (NOT BOOST_HTTP_MRDOCS_BUILD)
if (BOOST_HTTP_BUILD_TESTS)
set(BOOST_HTTP_UNIT_TEST_LIBRARIES asio filesystem)
🤖 Prompt for AI Agents
In `@CMakeLists.txt` around lines 77 - 79, The CMake conditional uses the wrong
variable name: change the check from BOOST_URL_MRDOCS_BUILD to the intended
BOOST_HTTP_MRDOCS_BUILD so the block governed by the existing option behaves
correctly; update the if condition that currently reads NOT
BOOST_URL_MRDOCS_BUILD to use NOT BOOST_HTTP_MRDOCS_BUILD (the other symbols in
the block are BOOST_HTTP_BUILD_TESTS and BOOST_HTTP_UNIT_TEST_LIBRARIES).

@MungoG MungoG merged commit 5ef14b2 into cppalliance:develop Jan 21, 2026
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants