-
Notifications
You must be signed in to change notification settings - Fork 11
cmake fix #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake fix #247
Conversation
📝 WalkthroughWalkthroughAdds new ignore entries to Changes
Sequence Diagram(s)sequenceDiagram
participant CI as CI Workflow
participant Repo as Source Repo
participant Corosio as cppalliance/corosio
participant Patch as Patch Step
participant Build as Build Job
CI->>Corosio: git clone corosio repo
CI->>Repo: remove existing corosio module (if any)
CI->>Patch: copy corosio-root -> libs/corosio
Patch->>Repo: apply corosio files into boost-root
CI->>Build: copy corosio artifacts into build workspace
Build->>Corosio: build/tests include corosio sources
Estimated code review effort🎯 4 (Complex) | ⏱️ ~40 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
An automated preview of the documentation is available at https://247.http.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-01-20 13:52:23 UTC |
|
GCOVR code coverage report https://247.http.prtest3.cppalliance.org/gcovr/index.html Build time: 2026-01-20 14:07:34 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@CMakeLists.txt`:
- Around line 77-79: The CMake conditional uses the wrong variable name: change
the check from BOOST_URL_MRDOCS_BUILD to the intended BOOST_HTTP_MRDOCS_BUILD so
the block governed by the existing option behaves correctly; update the if
condition that currently reads NOT BOOST_URL_MRDOCS_BUILD to use NOT
BOOST_HTTP_MRDOCS_BUILD (the other symbols in the block are
BOOST_HTTP_BUILD_TESTS and BOOST_HTTP_UNIT_TEST_LIBRARIES).
| if (NOT BOOST_URL_MRDOCS_BUILD) | ||
| if (BOOST_HTTP_BUILD_TESTS) | ||
| set(BOOST_HTTP_UNIT_TEST_LIBRARIES filesystem) | ||
| set(BOOST_HTTP_UNIT_TEST_LIBRARIES asio filesystem) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-existing issue: Variable name mismatch.
Line 77 checks BOOST_URL_MRDOCS_BUILD, but the option defined on line 40 is BOOST_HTTP_MRDOCS_BUILD. This means the condition NOT BOOST_URL_MRDOCS_BUILD will always evaluate to true (unless BOOST_URL_MRDOCS_BUILD is set externally), which may not be the intended behavior.
Suggested fix (outside the scope of this PR)
-if (NOT BOOST_URL_MRDOCS_BUILD)
+if (NOT BOOST_HTTP_MRDOCS_BUILD)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if (NOT BOOST_URL_MRDOCS_BUILD) | |
| if (BOOST_HTTP_BUILD_TESTS) | |
| set(BOOST_HTTP_UNIT_TEST_LIBRARIES filesystem) | |
| set(BOOST_HTTP_UNIT_TEST_LIBRARIES asio filesystem) | |
| if (NOT BOOST_HTTP_MRDOCS_BUILD) | |
| if (BOOST_HTTP_BUILD_TESTS) | |
| set(BOOST_HTTP_UNIT_TEST_LIBRARIES asio filesystem) |
🤖 Prompt for AI Agents
In `@CMakeLists.txt` around lines 77 - 79, The CMake conditional uses the wrong
variable name: change the check from BOOST_URL_MRDOCS_BUILD to the intended
BOOST_HTTP_MRDOCS_BUILD so the block governed by the existing option behaves
correctly; update the if condition that currently reads NOT
BOOST_URL_MRDOCS_BUILD to use NOT BOOST_HTTP_MRDOCS_BUILD (the other symbols in
the block are BOOST_HTTP_BUILD_TESTS and BOOST_HTTP_UNIT_TEST_LIBRARIES).
Summary by CodeRabbit
Chores
Chores / CI
✏️ Tip: You can customize this high-level summary in your review settings.