re-render canvas after 300ms to fix a bug on android where it stayed blank sometimes#59
Open
rbravo wants to merge 4 commits intocssivision:masterfrom
Open
re-render canvas after 300ms to fix a bug on android where it stayed blank sometimes#59rbravo wants to merge 4 commits intocssivision:masterfrom
rbravo wants to merge 4 commits intocssivision:masterfrom
Conversation
for fixing android bug where it stayed blank when opening on a modal sometimes
rbravo
changed the title
|
Any update on that? For me, it also doesn't work sometimes. But the fix seems to not always be working as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a QRCode on a Modal and a few times when opening the modal the Canvas stayed blank. So I called the draw method on the canvas again for it to repaint after 300ms, and it fixed the bug on android. Now everytime the QRCode shows up it paints (instantly or after 300ms).
Not the best fix in the world but it solves the problem =)