Config remote sync command #4289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 52c71ae
24 interesting tests: 22 KNOWN, 1 SKIP, 1 RECOVERED
Top 49 slowest tests (at least 2 minutes):
|
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
requested review from
andrewnester,
anton-107,
denik,
lennartkats-db,
pietern and
shreyas-goenka
as code owners
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Jan 21, 2026
Contributor
There was a problem hiding this comment.
Could you add some acceptance tests?
You can see examples here that modify remote resource:
% git ls-files | find . -type d | grep remote
./bundle/resources/permissions/jobs/deleted_remotely
./bundle/resources/permissions/jobs/added_remotely
./bundle/resources/permissions/jobs/reorder_remotely
./bundle/resources/volumes/remote-delete
./bundle/resources/volumes/remote-change-name
./bundle/resources/jobs/remote_add_tag
./bundle/resources/jobs/remote_matches_config
./bundle/resources/jobs/remote_delete
./bundle/resources/jobs/remote_delete/destroy
./bundle/resources/jobs/remote_delete/deploy
./bundle/resource_deps/remote_field_storage_location
./bundle/resource_deps/remote_app_url
./bundle/resource_deps/remote_app_url/app
./bundle/resource_deps/jobs_update_remote
./bundle/resource_deps/remote_pipeline
| schema Generate JSON Schema for bundle configuration | ||
| summary Summarize resources deployed by this bundle | ||
| sync Synchronize bundle tree to the workspace | ||
| validate Validate configuration |
Contributor
There was a problem hiding this comment.
The output seems to be the same except for whitespace?
Contributor
Author
There was a problem hiding this comment.
Yes, probably a bug in help/Cobra? New command is hidden, but help reserves space for it.
| isDefault: isEmptyStruct, | ||
| }, | ||
| { | ||
| pattern: regexp.MustCompile(`^webhook_notifications$`), |
Contributor
There was a problem hiding this comment.
You can probably drop these, they now using different reason: #4338
Contributor
Author
There was a problem hiding this comment.
Yep that works good now, thanks!
denik
reviewed
Jan 21, 2026
| currentValue := b.Config.Value() | ||
|
|
||
| for i, n := range nodes { | ||
| if key, ok := n.StringKey(); ok { |
Contributor
There was a problem hiding this comment.
StringKey might be rendered with a dot or with [""] or with [''] depending on string contents.
I suggest to output PathNode and then convert it to string rather than recreate the string directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
New experimental command
databricks bundle config-remote-sync. The command fetches the latest remote changes of resources and compares them to the deployed state. With the--saveflag, it also writes changes back to YAML files.The command leverages the diffing algorithm of the
bundle plancommand. Also note that new dependency is added to do yaml patching that preserves commentsThis is a first PR, I will continue fixing all limitations in the next PRs
Current limitations:
bundle plantasks[task_key='my_task']need to be tested for cases when the object or parent doesn't existNo changelog entries are needed as the command is intended to be private for now, and we don't want to encourage users to use it due to the unstable API
Why
This command serves as the backend for the new visual authoring feature in DABs in the Workspace.
User edits job or pipeline in the Workspace UI, then clicks the "Sync" button, and then the new command applies the diff to the source configuration files. Then the user may accept or reject these changes in the editor
Tests
Currently, only unit tests to speed up devloop, but once I have full functionality, I'll add proper acceptance test coverage
Acceptance tests are failing because of the change in formatting (even though the command is hidden)