Token Federation for Go Driver (3/3) #292
Conversation
Two comprehensive examples demonstrating token provider usage: 1. token_federation: Simple external token provider with federation 2. browser_oauth_federation: Full browser OAuth flow with automatic token exchange Both examples show real-world integration patterns for custom authentication. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
madhav-db
requested review from
deeksha-db,
gopalldb,
jackyhu-db,
jadewang-db,
jayantsing-db,
jprakash-db,
samikshya-db,
shivam2680 and
vikrantpuppala
as code owners
| case 3: | ||
| s += "=" | ||
| } | ||
| return io.ReadAll(strings.NewReader(s)) |
There was a problem hiding this comment.
is this intentionally left as such? you are actually not decoding anything
|
|
||
| // Helper: Test database connection with queries | ||
| func testConnection(db *sql.DB) error { | ||
| ctx, cancel := context.WithTimeout(context.Background(), 120*time.Second) |
There was a problem hiding this comment.
shall we suggest lower timeout value in our examples? Or 120s was intentional?
There was a problem hiding this comment.
Pull request overview
This pull request adds two comprehensive example programs demonstrating token provider usage for authentication in the Databricks Go SQL driver. The examples showcase both simple token federation with external providers and a complete browser-based OAuth flow with automatic token exchange.
Changes:
- Added
token_federationexample showing three authentication patterns: static tokens, external token functions, and custom TokenProvider implementations - Added
browser_oauth_federationexample demonstrating User-to-Machine (U2M) OAuth authentication with interactive browser login
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/token_federation/main.go | Implements three token authentication patterns with a custom ExpiringTokenProvider demonstrating token lifecycle management |
| examples/browser_oauth_federation/main.go | Demonstrates U2M OAuth flow with browser-based authentication and connection validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| func (p *ExpiringTokenProvider) GetToken(ctx context.Context) (*tokenprovider.Token, error) { | ||
| p.expiresAt = time.Now().Add(p.lifetime) |
There was a problem hiding this comment.
The ExpiringTokenProvider modifies shared state (p.expiresAt) without synchronization. If GetToken is called concurrently from multiple goroutines, this could result in race conditions. Consider adding a mutex to protect access to expiresAt.
Two comprehensive examples demonstrating token provider usage:
Both examples show real-world integration patterns for custom authentication.