test: Verify fix for Issue #24 with regression test#51
Open
NakulSingh156 wants to merge 2 commits intodbpedia:mainfrom
Open
test: Verify fix for Issue #24 with regression test#51NakulSingh156 wants to merge 2 commits intodbpedia:mainfrom
NakulSingh156 wants to merge 2 commits intodbpedia:mainfrom
Conversation
📝 WalkthroughWalkthroughThis PR adds a regression test for handling URLs without content variants and updates test expectations following changes to the deployment API signature and response structure for artifact/version relationships. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
I investigated Issue #24 ("deploy related -> content variant issue") where a specific URL format was reported to cause an
IndexError.I attempted to reproduce the crash using the current
mainbranch, but the issue appears to be already resolved (likely by the existing safety checkif len(args) < 2).To ensure this remains fixed and to close the issue, I have added a regression test case in
tests/test_deploy.pythat uses the exact input reported in the issue.Changes:
Added unit test case to
test_get_content_variantsverifying that a URL without variant segments returns{}instead of crashing.Related Issues
Resolves #24.
Type of change
Checklist:
poetry run pytest- all tests passedpoetry run ruff check- no linting errorsSummary by CodeRabbit
Release Notes
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.