Wait for sysfs node to ready before access (API BREAK)#16
Open
nocko wants to merge 1 commit intoderekstavis:masterfrom
nocko:deferred-alloc-take2
Open
Wait for sysfs node to ready before access (API BREAK)#16nocko wants to merge 1 commit intoderekstavis:masterfrom nocko:deferred-alloc-take2
nocko wants to merge 1 commit intoderekstavis:masterfrom
nocko:deferred-alloc-take2
Conversation
Owner
|
Thanks for the PR @nocko! Good job here! 🍻 I would suggest not breaking the API. We have two ways of doing this:
This way we can publish to PyPI and keep compatibility, while allowing new implementations to wait for pin availability. What's your opinion on the more appropriate solution? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With current versions of sysfs-gpio on Raspberry Pi, the first run of the application would fail (Permission Denied on SYSFS_GPIO_VALUE_PATH); but the second time (or if the pins were already exported); the library works fine.
As it turns out, on Raspberry Pi (Raspbian Jessie); it takes some time for the sysfs nodes under the GPIO pin to have the correct permissions assigned if you're not running your application as root.
Doing a time.sleep(0.5) works, but is dirty. This branch attempts to do it the "Right Way"; BUT that means Controller.alloc_pin() returns a deferred... which breaks existing code.
On the other hand, the raspberry pi may be the most commonly used / available python+GPIO hardware target so having the library work there is good.