[release/10.0] Fix HandleTransactionCompleted test flakiness #37520
+39
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: AndriySvyryd <[email protected]>
Copilot
AI
changed the title
[WIP] Port changes from PR #37101 to release 10.0
Port fix for flaky transaction race test
Jan 15, 2026
AndriySvyryd
changed the title
AndriySvyryd
changed the title
There was a problem hiding this comment.
Pull request overview
This PR ports a fix for a flaky concurrency test that verifies thread safety between HandleTransactionCompleted and ClearTransactions in the RelationalConnection class. The original test had unreliable race condition triggering because it randomly chose operation order. The new implementation explicitly tests both orderings of operations to ensure the race condition is properly exercised.
Changes:
- Converted test from synchronous to async
- Split test into two explicit scenarios instead of random ordering
- First scenario: calls
scope.Complete()beforeResetState() - Second scenario: calls
ResetState()with a delay beforescope.Complete()
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #37101
Fix the flaky test by properly creating a race condition between HandleTransactionCompleted and ClearTransactions.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.