Conversation
|
✅Static analysis result - no issues found! ✅ |
There was a problem hiding this comment.
Pull Request Overview
This PR updates project dependencies by removing unused submodules and adjusting configurations to align with the latest dependency versions and APIs. Key changes include replacing the espp and esp-protocols submodules with idf-component-manager dependencies, updating the SPIRAM configurations in sdkconfig.defaults, and modifying code and workflows to use the latest espp::Task API and ESP-IDF v5.4.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdkconfig.defaults | Updated SPIRAM configuration options to use malloc and 120M speed |
| main/main.cpp | Modified task initialization to match the new espp::Task API |
| main/idf_component.yml | Added dependency manifest for idf-component-manager |
| components/jpegdec | Updated submodule commit for jpegdec |
| components/espp & components/esp-protocols | Removed submodules for espp and esp-protocols |
| CMakeLists.txt | Removed obsolete extra component directories |
| .gitmodules | Removed espp and esp-protocols submodule definitions |
| .github/workflows/static_analysis.yml | Updated ESP-IDF version and removed submodule exclusions for cppcheck |
| .github/workflows/package_main.yml | Updated workflow steps to reflect removal of submodules and add intermediary outputs |
| .github/workflows/build.yml | Updated submodules checkout option and ESP-IDF version |
Comments suppressed due to low confidence (2)
main/main.cpp:181
- The new designated initializer for espp::Task::make_unique requires that Task be an aggregate type or otherwise support such initialization. Verify that the Task API in use and the C++ standard in your build environment support designated initializers.
auto display_task = espp::Task::make_unique({.callback = display_task_fn,
.github/workflows/build.yml:14
- Ensure that using 'submodules: true' behaves equivalently to the previous 'recursive' option in terms of fetching all necessary submodules. This verification helps avoid potential issues if repository submodule structures change in the future.
submodules: true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
esppsubmodule, instead using idf-component-manager dependenciesesp-protocolssubmodule, instead usingidf-component-managerdependenciesjpegdecsubmodule to latestespp::TaskAPIMotivation and Context
Keeps this repo up to date with latest features and bugfixes.
How has this been tested?
Building and running
mainonESP-S3-BOXhardware and ensuring it still receives the video data and decodes/displays it appropriately.Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.