fix: add IsBlockComplete check to prevent gap detection race condition#79
Closed
Savid wants to merge 1 commit intofeat/redis-stale-detection-optimizationfrom
Closed
Conversation
Add verification that a block is still incomplete in ClickHouse before calling ReprocessBlock in gap detection. This closes a TOCTOU race window where a block could complete (MarkBlockComplete writes complete=1 and cleans up Redis tracking) between when gap detection queries ClickHouse and when it decides to reprocess. Previously, gap detection only checked HasBlockTracking() which returns false after a block completes and Redis is cleaned up, causing already- complete blocks to be unnecessarily reprocessed. - Add IsBlockComplete() to state manager for fresh ClickHouse query - Add completion check in checkGaps() before ReprocessBlock call - Add unit test for race condition logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add verification that a block is still incomplete in ClickHouse before calling ReprocessBlock in gap detection. This closes a TOCTOU race window where a block could complete (MarkBlockComplete writes complete=1 and cleans up Redis tracking) between when gap detection queries ClickHouse and when it decides to reprocess.
Previously, gap detection only checked HasBlockTracking() which returns false after a block completes and Redis is cleaned up, causing already- complete blocks to be unnecessarily reprocessed.