Conversation
Member
|
eosvm doesn't seem to show up in the charts? |
Member
Author
|
I have rebased |
Member
|
Can you add eosvm to the README? |
axic
reviewed
Aug 6, 2020
jwasinger
suggested changes
Aug 10, 2020
Contributor
jwasinger
left a comment
jwasinger
left a comment
There was a problem hiding this comment.
The notebook is going to be removed from the repo: #152 . Can you move notebook changes in this PR to the new script for generating charts: https://github.com/ewasm/benchmarking/blob/master/notebooks/wasm-engines.py ?
Member
Author
|
I already modified the script https://github.com/ewasm/benchmarking/pull/150/files#diff-a6dee7477faf26016717d019cdc8bf1b , althought I modify it manually, do you want me to use the nbconvert tool instead? |
Member
Author
|
Now I converted the notebook to a script, and included the charts generated by the script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.