Fix bug with URL encoding and binder bare Git#911
Open
zergar wants to merge 3 commits intoexecutablebooks:masterfrom
Open
Fix bug with URL encoding and binder bare Git#911zergar wants to merge 3 commits intoexecutablebooks:masterfrom
zergar wants to merge 3 commits intoexecutablebooks:masterfrom
Conversation
zergar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you use https://mybinder.org/ to launch binder on a standard git repo (i.e., not GitHub or GitLab), in the URL slashes are URL-encoded. This, however, is not reflected in this codebase, where slashes are kept as-is.
This PR sets safe characters to empty in order to also encode slashes in the repository URL.