[example][apollo-client][react-navigation] fix type errors#82
Merged
Conversation
Kudo
commented
Oct 13, 2025
| } | ||
|
|
||
| function TestCase<T>({ title, route }: { title: string; route: LinkProps<T>['href'] }) { | ||
| function TestCase({ title, route }: { title: string; route: LinkProps['href'] }) { |
Collaborator
Author
There was a problem hiding this comment.
LinkProps is not generic type from newer expo-router
|
|
||
| export function useReactNavigationDevTools(ref: React.RefObject<NavigationContainerRef<any>>) { | ||
| export function useReactNavigationDevTools( | ||
| ref: React.RefObject<NavigationContainerRef<any> | null> |
| globalThis.__REDUX_DEVTOOLS_EXTENSION__ = { | ||
| connect: () => adapterRef.current, | ||
| }; | ||
| // @ts-ignore: useReduxDevToolsExtension does not accept null ref from NavigationContainerRefWithCurrent |
Collaborator
Author
There was a problem hiding this comment.
i guess the problem is actually from react-navigation/devtools
| "expo": "53.0.7", | ||
| "expo-module-scripts": "^4.1.7", | ||
| "graphql": "^16.9.0", | ||
| "react-dom": "19.1.0", |
Collaborator
Author
There was a problem hiding this comment.
bun adds @apollo/client as different dep that example's apollo-client has react-dom peerDep and this plugin does not.
to resolve the type error, this is a workaround to add react-dom from the plugin, so that bun can treat the apollo/client as same package and same type
vonovak
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
fix typecheck errors
fixes #70
How
@apollo/client. to workaround this, i have to add react-dom devDeps to the apollo plugin, so bun will keep the same resolutionTest Plan
add typecheck to ci