⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@benflexcompute
Copy link
Collaborator

@benflexcompute benflexcompute commented Jan 16, 2026

Note

Updates boundary completeness validation to be less strict under Geometry AI.

  • Adds use_geometry_AI to _validate_boundary_completeness and passes param_info.use_geometry_AI, downgrading missing-BC errors to warnings when enabled
  • Adjusts tests/simulation/params/test_automated_farfield.py to capture warnings from validate_model and assert warning messages instead of errors for missing BCs
  • Adds tests in test_validators_params.py to explicitly verify missing BCs are warnings with Geometry AI and errors without it
  • Extends farfield/legacy-asset tests to cover warning behavior when private_attributes are missing and when transformations/mirroring are present

Written by Cursor Bugbot for commit 2126b2f. This will update automatically on new commits. Configure here.

@benflexcompute benflexcompute merged commit 71a9d2f into main Jan 16, 2026
21 checks passed
@benflexcompute benflexcompute deleted the BenY/GAITriggersWarningInsteadOfError branch January 16, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants