⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@spalmurray
Copy link
Collaborator

@spalmurray spalmurray commented May 5, 2025

Updates build and release workflows to work with new package structure and repo.

Notable changes:

  • We're moving from our codecov-releaser bot account to the recommended Sentry Release Bot GitHub App.
  • I've removed the commit signing step from the release PR creation flow as it seems we probably don't care enough to do the extra work needed to set this up based on this workflow in the main monorepo.

I have tested all workflows with the exception of release_flow.yml as it needs secrets we don't yet have (working on it).

Next PR will add the build steps for prevent-cli, this one is only getting codecov-cli to work.

After this is merged, we should be able to start publishing codecov-cli from this repo exclusively.

@codecov
Copy link

codecov bot commented May 5, 2025

❌ 10 Tests Failed:

Tests completed Failed Passed Skipped
7010 10 7000 60
View the top 3 failed test(s) by shortest run time
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@spalmurray spalmurray force-pushed the spalmurray/remaining-workflows-for-cccli branch from 678ad31 to ba71078 Compare May 5, 2025 15:36
@spalmurray spalmurray marked this pull request as ready for review May 5, 2025 18:11
@spalmurray spalmurray force-pushed the spalmurray/remaining-workflows-for-cccli branch from 06116fe to b0e2965 Compare May 5, 2025 18:49
@spalmurray spalmurray changed the title feat: Update release workflows feat: Update build/release workflows May 5, 2025
@@ -0,0 +1,164 @@
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI some of this file might be able to be axed due to codecov/codecov-cli#664

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good shout tyty

id-token: write # This is required for OIDC
runs-on: ubuntu-latest
environment:
name: pypi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to create this environment in GitHub

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ty!

@@ -1,4 +1,5 @@
#!/bin/sh
cd codecov-cli
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only building the codecov-cli? do we need to do this for prevent-cli?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that will be another PR

Copy link
Collaborator

@thomasrockhu-codecov thomasrockhu-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to update the settings on this repo to allow issues also

@spalmurray spalmurray merged commit ac6a04a into main May 9, 2025
22 of 23 checks passed
@spalmurray spalmurray deleted the spalmurray/remaining-workflows-for-cccli branch May 9, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants