Dataflow: Delete the old configuration-class based api.#18191
Merged
aschackmull merged 17 commits intogithub:mainfrom Dec 4, 2024
Merged
Dataflow: Delete the old configuration-class based api.#18191aschackmull merged 17 commits intogithub:mainfrom
aschackmull merged 17 commits intogithub:mainfrom
Conversation
hvitved
previously approved these changes
Dec 3, 2024
aschackmull
force-pushed
the
dataflow/remove-deprecated-lib
branch
2 times, most recently
from
92c1c44 to
fce737f
Compare
adityasharad
reviewed
Dec 3, 2024
| --- | ||
| category: breaking | ||
| --- | ||
| * Deleted the old deprecated data flow api that was based on extending a configuration class. |
Collaborator
There was a problem hiding this comment.
Something like this will help any remaining users migrate.
Suggested change
| * Deleted the old deprecated data flow api that was based on extending a configuration class. | |
| * Deleted the old deprecated data flow API that was based on extending a configuration class. See https://github.blog/changelog/2023-08-14-new-dataflow-api-for-writing-custom-codeql-queries for instructions on migrating your queries to use the new API. |
aschackmull
force-pushed
the
dataflow/remove-deprecated-lib
branch
2 times, most recently
from
91f4c6a to
aee18c7
Compare
aschackmull
force-pushed
the
dataflow/remove-deprecated-lib
branch
from
aee18c7 to
8c99ad4
Compare
jketema
approved these changes
Dec 3, 2024
hvitved
approved these changes
Dec 4, 2024
yoff
approved these changes
Dec 4, 2024
Contributor
yoff
left a comment
yoff
left a comment
There was a problem hiding this comment.
Python 👍 we are just deleting several deprecated classes :-)
owen-mc
approved these changes
Dec 4, 2024
Contributor
owen-mc
left a comment
owen-mc
left a comment
There was a problem hiding this comment.
Go (again, as there were more changes) 👍🏻
Contributor
Author
|
Alrighty, let's merge this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 🎉 This deletes the old and long-deprecated data flow api that was based on extending a configuration class.
See also the blog post https://github.blog/changelog/2023-08-14-new-dataflow-api-for-writing-custom-codeql-queries/ where we announced that this would happen now.