-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(cli): pass log_level to uvicorn in web and api_server commands #4144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): pass log_level to uvicorn in web and api_server commands #4144
Conversation
Summary of ChangesHello @kotaitos, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly passes the log_level from the adk web and adk api_server commands to the underlying uvicorn server. The change is simple, effective, and uses .lower() to match the format expected by uvicorn. The manual testing described in the PR description confirms that the fix works as intended. The changes look good. The other modifications in the sample files are minor whitespace changes.
Explicitly pass the log_level parameter to uvicorn.Config in both adk web and adk api_server commands. This ensures that Uvicorn's internal logging respects the configured log level. Closes google#4139
1468b86 to
a454f1e
Compare
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Testing Plan
Unit Tests:
Existing unit tests pass. This change affects the CLI execution flow which is better verified via manual E2E tests.
Manual End-to-End (E2E) Tests:
I verified the fix by running
adk webwith different log levels.Verify WARNING level (Suppression):
Run:
adk web --log_level=WARNING contributing/samples/hello_worldResult: The standard Uvicorn INFO logs ("Application startup complete", etc.) are not displayed. Only
click.sechooutputs andUserWarnings are visible.Verify INFO level (Default/Explicit):
Run:
adk web --log_level=INFO contributing/samples/hello_worldResult: The standard Uvicorn INFO logs are displayed as expected.
Checklist