⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@kotaitos
Copy link
Contributor

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

Testing Plan

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Existing unit tests pass. This change affects the CLI execution flow which is better verified via manual E2E tests.

Manual End-to-End (E2E) Tests:

I verified the fix by running adk web with different log levels.

  1. Verify WARNING level (Suppression):
    Run: adk web --log_level=WARNING contributing/samples/hello_world
    Result: The standard Uvicorn INFO logs ("Application startup complete", etc.) are not displayed. Only click.secho outputs and UserWarnings are visible.

  2. Verify INFO level (Default/Explicit):
    Run: adk web --log_level=INFO contributing/samples/hello_world
    Result: The standard Uvicorn INFO logs are displayed as expected.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works. (Verified manually as CLI behavior)
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kotaitos, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the log_level specified via the command-line interface was not being propagated to the Uvicorn server when running adk web or adk api_server. By ensuring the log_level is correctly passed, this change allows users to effectively manage the verbosity of Uvicorn's internal logging, improving the clarity of console output during development and execution.

Highlights

  • Uvicorn Log Level Fix: The log_level argument is now correctly passed to the Uvicorn server when using adk web and adk api_server commands, resolving issue Setting log_level to WARNING still shows info messages (dev UI) #4139.
  • Logging Control: Users can now effectively control Uvicorn's log output via the --log_level CLI flag, allowing for suppression of default INFO messages or explicit display.
  • Code Formatting: Minor formatting adjustments were made in two sample files by removing unnecessary blank lines.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adk-bot adk-bot added the tools [Component] This issue is related to tools label Jan 13, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly passes the log_level from the adk web and adk api_server commands to the underlying uvicorn server. The change is simple, effective, and uses .lower() to match the format expected by uvicorn. The manual testing described in the PR description confirms that the fix works as intended. The changes look good. The other modifications in the sample files are minor whitespace changes.

Explicitly pass the log_level parameter to uvicorn.Config in both
adk web and adk api_server commands. This ensures that Uvicorn's
internal logging respects the configured log level.

Closes google#4139
@kotaitos kotaitos force-pushed the fix/uvicorn-log-level-4139 branch from 1468b86 to a454f1e Compare January 13, 2026 15:01
@ankursharmas ankursharmas merged commit 38d52b2 into google:main Jan 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools [Component] This issue is related to tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting log_level to WARNING still shows info messages (dev UI)

3 participants