-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(anthropic): handle arbitrary dictionary tool outputs #4150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(anthropic): handle arbitrary dictionary tool outputs #4150
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @QuentinFuxa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue in the Anthropic LLM integration within the ADK, specifically concerning how tool outputs are interpreted by the Claude model. By making the tool response parsing more flexible and robust, it ensures that Claude can correctly process diverse tool outputs, thereby enhancing the reliability and interoperability of agents utilizing these models. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Response from ADK Triaging Agent Hello @QuentinFuxa, thank you for creating this PR! This PR is a bug fix, could you please associate the github issue with this PR? If there is no existing issue, could you please create one? In addition, could you please add unit tests for your change? This information will help reviewers to review your PR more efficiently. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively addresses the issue of handling arbitrary dictionary tool outputs for the Claude model. The logic to stringify the entire response dictionary as a fallback is a solid approach. I've added one minor suggestion to improve code robustness by ensuring type checks are consistent. Additionally, I recommend adding a new unit test case to tests/unittests/models/test_anthropic_llm.py that specifically covers this new fallback behavior with an arbitrary dictionary (e.g., {'status': 'success', 'data': [...]}). This will help prevent future regressions and verify the fix.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
The
Claudemodel implementation ingoogle-adkfails to pass tool results to the model if the tool's output dictionary doesn't explicitly contain a"result"key.In the current implementation of
part_to_message_blockforfunction_response, the code initializescontent = ""and only populates it if"result"is present in the response dictionary. As a result, tools returning standard result structures (like{"status": "success", "data": [...]}) appear to have empty outputs to the Claude model, making tool use unreliable or non-functional.Solution:
Modify the
function_responsehandling ingoogle/adk/models/anthropic_llm.pyto be more robust:"result"key, extract its value (preserving existing behavior).ToolResultBlockParamrequirements.Testing Plan
Unit Tests:
Manual End-to-End (E2E) Tests:
google.adk.models.anthropic_llm.Claude."result"key (e.g.,return {"status": "success", "data": [1, 2, 3]}).""as tool output and claims it doesn't see any data."{'status': 'success', 'data': [1, 2, 3]}"and correctly processes the information.Checklist
Additional context
This fix is critical for interoperability between Gemini and Claude models within the ADK, as it allows tools designed for Gemini's flexible output handling to work seamlessly with Claude without requiring tool-specific modifications.