feat: Migrates the dds-datasets-point sample.#1073
Merged
Conversation
|
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
Commented out the line that sets the dataset layer style.
Commented stuff out for testing.
Take everything out in an vain attempt to figure out why tests fail on a 400 error.
Removed EVERYTHING to see if we can figure out WTF is causing test to fail.
Comment out the map-id attribute in the gmp-map element.
Removed commented-out map-id attribute from gmp-map.
Change to set map ID programmatically since apparently the map ID is causing the test to fail (flaky).
Change to DEMO_MAP_ID to see if we can repro the 400 error on the test.
Removed setting map options for innerMap.
Replace new map ID with the one from the previous version, for testing.
testing with the old one (goes with the map ID that's in use for testing)
Restoring to the map ID we want to use.
Restoring to the dataset ID we want to use.
|
LGTM |
miraleung
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following things: