Open
Conversation
jiawen
force-pushed
the
jiawen-hl_main
branch
from
62a5895 to
9bae1f1
Compare
Contributor
Author
|
Any suggestions on how / where to put tests? A simple test would be to use something like |
jiawen
commented
Feb 7, 2026
| if (result != 0) { | ||
| // Some paths in generate_filter_main() will fail with user_error or similar (which throws an exception | ||
| // due to how libHalide is built for Python), but some paths just return an error code. For consistency, | ||
| // handle both by throwing a C++ exception, which pybind11 turns into a Python exception. |
Contributor
Author
There was a problem hiding this comment.
I updated this comment to be more clear.
alexreinking
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.