Conversation
Contributor
|
This is very hard to review because it has a slew of formatting changes along with substantive ones. Please separate those out into another commit. One or two are fine, but when there's a huge bunch it makes things really hard. |
Member
Author
|
Understandable; sorry about that. Give me a moment. |
Member
Author
|
see #71 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue: #54
Don't merge yet, some unresolved questions:
Enumeratorpart of theListTAPI frompipes? I have not done so here.exceptionsto provideMonadCatchandMonadThrowinstances forListT? There seems to already be the desire to incur this dependency onexceptionsin issue [Discussion] Should we bring back exceptions instances? #52.ListT, or should it be something else?