⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@Justin113D
Copy link
Contributor

  • All structures now have IBinarySerializable implemented to read structures via ReadObject<T> than Read<T>, since the latter will attempt to use Linq.Expressions to convert between Big and Small Endian, which is not supported for AOT (or at the very least does not work here).
    • Since native structures like System.Numberics.Vector3 can't have IBinarySerializable implemented, the structures received read/write extension methods via the new class SharpNeedle.Utilities.StructBinaryHelper to ensure correct endian reading/writing
  • All read/write calls for native types now use their Non-generic counterparts (e.g. Read<int>() -> ReadInt32())
  • Improved Parameter reading for SharpNeedle.Framework.SonicTeam.DiEvent Parameters - They are no longer being called via Constructurs, as that is bad practice, and will now instead be read using ReadObject
  • V1 Sample chunk resources no longer use substream for reading data
  • Removed RhuBullet dependency and its BVH generation implementation due to the nugets incomplete state
  • Some things were made public to allow for JSON deserialization in aot:
    • class SharpNeedle.Framework.HedgehogEngine.Mirage.SampleChunkNode.JsonConverter
    • constructor SharpNeedle.Framework.HedgehogEngine.Mirage.ModelData.MeshSlot(MeshType type, string name)

@blueskythlikesclouds
Copy link
Member

Sajid don't you dare LGTM this one, I'll look at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants