Fix silent auth redirect with expired client credentials #4181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgent
force-pushed
the
fix/expired-client-silent-auth
branch
from
d02584a to
ecac935
Compare
Contributor
|
Thanks for opening this PR! I'll have a look as soon as possible :) |
timgent
force-pushed
the
fix/expired-client-silent-auth
branch
2 times, most recently
from
b3b7d29 to
091227c
Compare
NSeydoux
reviewed
Feb 6, 2026
packages/browser/src/Session.ts
Outdated
Comment on lines
88
to
98
| // Check if the client registration has expired before attempting silent auth. | ||
| // Expiration only applies to confidential clients (those with a secret). | ||
| // clientExpiresAt === 0 means the registration never expires. | ||
| // clientExpiresAt === undefined with a secret means legacy data — treat as expired. | ||
| if (storedSessionInfo.clientAppSecret !== undefined) { | ||
| const expiresAt = storedSessionInfo.clientExpiresAt ?? -1; | ||
| if (expiresAt !== 0 && Math.floor(Date.now() / 1000) > expiresAt) { | ||
| window.localStorage.removeItem(KEY_CURRENT_SESSION); | ||
| return false; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Can this check be moved up to validateCurrentSession?
Author
There was a problem hiding this comment.
Yep fair point, will update when I find a few mins 👍
timgent
force-pushed
the
fix/expired-client-silent-auth
branch
from
b0e4770 to
ebaee2b
Compare
When client credentials expire, the silent authentication flow now correctly detects the expiration and gracefully falls back to a logged-out state instead of redirecting to the OAuth provider and showing an error page. Adds a clientExpiresAt field to ISessionInternalInfo, reads it from storage in SessionInfoManager, and updates the CHANGELOG. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
timgent
force-pushed
the
fix/expired-client-silent-auth
branch
from
ebaee2b to
0930fdd
Compare
Contributor
|
I'm sorry, I didn't realize until now your commits weren't signed. We have a branch protection rule requiring signed commit. I can sign the commit myself, but for proper attribution I'd prefer that you setup signing keys if it's okay with you. Github provides some intructions on how to do this. If it's too much of a bother, I can go ahead with my own signature, but I would prefer you get full credit for your work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bug #4177.
Summary
When
handleIncomingRedirect({ restorePreviousSession: true })is called with stored session data containing an expiredclient_id, the library now validates client expiration before attempting silent authentication. This prevents the redirect to the OAuth provider with invalid credentials, which previously caused users to be stuck on an error page.Changes
clientExpiresAtfield toISessionInternalInfoso client expiration data flows through the existingSessionInfoManager.get()→validateCurrentSession()→silentlyAuthenticate()pathexpiresAtfrom storage in the browserSessionInfoManager.get()and return it asclientExpiresAtsilentlyAuthenticate()using the session info fields, rather than a separate methodDesign
Rather than adding a separate
isClientExpired()method and threadingstorageUtilitythrough theClientAuthenticationconstructor, the expiration timestamp is surfaced as part of the session info that already gets retrieved during silent auth. This keeps the change minimal and avoids extra constructor parameters, mock plumbing, and redundant storage reads.Checklist
🤖 Generated with Claude Code