-
Notifications
You must be signed in to change notification settings - Fork 807
Reapply "[CI][SYCL] Enable E2E testing for New Offloading Model" (#20634)" #21036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
In this patch |
| e2e_binaries_preview_artifact: | ||
| type: string | ||
| required: false | ||
| e2e_binaries_new_offload_model_artifact: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind doing a manual run of this?
To do that, push your branch to intel/llvm but not to the sycl branch, to some new branch like nightly_e2e_test or something.
Then, go here
https://github.com/intel/llvm/actions/workflows/sycl-nightly.yml
and on the top rihgt click "Run workflow' and select the branch you made.
After you submit it, hit refresh and the pending nightly job in the list will be the one you just made.
When it's done, please post the log link here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the testing done in this PR's CI not sufficient? sycl-linux-precommit reuses sycl-linux-build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that sycl-linux-precommit doesn't use sycl-linux-build. So we really should check it manually as you suggest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, for some reason I thought this change was for the nightly only.
If we look at the CI results in this PR
https://github.com/intel/llvm/actions/runs/21002533524/job/60379060956?pr=21036
https://github.com/intel/llvm/actions/runs/21002533381/job/60379088909?pr=21036
We can see it seems to be running the new offload model tests, so I think it's working
sycl-linux-precommit should use sycl-linux-build here https://github.com/intel/llvm/blob/sycl/.github/workflows/sycl-linux-precommit.yml#L56.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the result for linux: https://github.com/intel/llvm/actions/runs/21066409654/job/60584763744
Failing tests are identical for NewOffloadModel and OldOffloadModel.
Here is the result for windows: https://github.com/intel/llvm/actions/runs/21066409654/job/60584763801
I have found one mistake which will be fixed soon.
sarnex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thx!
|
lol i am in too many code review groups |
Reapply of #20634
This patch has the following changes:
--param enable_new_offload_modelis added to SYCL E2E LIT test configuration