-
Notifications
You must be signed in to change notification settings - Fork 807
[WIP][SYCL][test] Enable multi_lib_app test for CUDA and HIP backends #21044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kekaczma
wants to merge
3
commits into
sycl
Choose a base branch
from
multi-lib-cuda-hip-fix
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01b2a4f to
64abd52
Compare
c268e42 to
560d057
Compare
a12d339 to
1c87f66
Compare
1c87f66 to
27a5fa1
Compare
27a5fa1 to
4b4572a
Compare
4b4572a to
4e686a9
Compare
The test was marked UNSUPPORTED for CUDA/HIP because libraries were
compiled without backend-specific targets, generating only SPIR-V
device code which CUDA/HIP cannot execute.
Changes:
- Remove UNSUPPORTED directive for cuda/hip
- Add %{target} macro for backend-specific compilation
- CUDA: -fsycl-targets=nvptx64-nvidia-cuda
- HIP: -fsycl-targets=amdgcn-amd-amdhsa with detected arch
- Add %amd_arch_options substitution in lit.cfg.py to provide
required --offload-arch flag for HIP (detected from device or
defaulting to gfx1030 in build-only mode)
The test now passes on all three backends (Level Zero, CUDA, HIP).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was previously disabled for CUDA/HIP because shared libraries were compiled without backend-specific targets, generating only SPIR-V device code. CUDA and HIP require PTX and AMDGCN respectively.
This change adds %cuda_options to compilation commands, which expands to:
This allows the test to run on all backends with appropriate device code.