Implement EIP-8024 #1429
Open
Implement EIP-8024 #1429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
commented
Jan 30, 2026
lib/evmone/advanced_analysis.cpp
Outdated
| ++code_pos; | ||
| } | ||
| else | ||
| rollback_block(); |
Author
There was a problem hiding this comment.
This rollback approach doesn't look great to me.
@chfast What do you think? How should "conditional" stack change be implemented?
It's not exactly conditional either because either the stack height changes (on DUPN) or the frame reverts due to invalid instruction.
Member
There was a problem hiding this comment.
You can ignore the advanced interpreter (disable it in relevant unit tests).
Author
There was a problem hiding this comment.
Removed changes to the advanced interpreter.
frangio
force-pushed
the
eip-8024
branch
2 times, most recently
from
3fc2e51 to
d7c8b12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1428 this was coded by AI and I don't have enough context to judge it.