Add OS icons for graphical desktop clients#381
Open
progval wants to merge 11 commits intoircv3:masterfrom
Open
Add OS icons for graphical desktop clients#381progval wants to merge 11 commits intoircv3:masterfrom
progval wants to merge 11 commits intoircv3:masterfrom
Conversation
Member
|
I don't mind this but let me look into the table changes first (it's a tiny bit unwieldy with the current layout). I may split this into a separate column depending on stickyness of the top/left headers |
Contributor
Author
|
Sure, no hurry |
I'm not adding them for glirc or BitchX, because their websites are (respectively) not providing the info and broken.
Member
|
We'll need to update FontAwesome to get the bsd icon but we can worry about that later. For now could you add this to .os-support-macos {
color: #444;
}
.os-support-windows {
color: #4d75b3;
}
.os-support-linux {
color: #826d2e;
}
.os-support-bsd {
color: #a42f2f;
}bitchx and swirc both support all of the OSes, according to their websites/install instructions. I think Glirc supports all of them as well? |
Contributor
|
It's probably fine to just group BSD and Linux under a general "UNIX" category. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't add icons to Terminal Clients, so this PR does not conflict with #380
I'll add them if we decide to merge this PR before #380.
Note that the "freebsd" icon isn't displayed because we use FontAwesome 4, and it was added in FontAwesome 5.