[Fix] Change deprecated $class->properties call#126
Open
davidindra wants to merge 1 commit intojanmarek:masterfrom
davidindra:patch-1
Open
[Fix] Change deprecated $class->properties call#126davidindra wants to merge 1 commit intojanmarek:masterfrom davidindra:patch-1
davidindra wants to merge 1 commit intojanmarek:masterfrom
davidindra:patch-1
Conversation
updated to $class->getProperties() to avoid "User Deprecated: Missing annotation @Property for Nette\PhpGenerator\ClassType::$properties" exception
Author
|
I can't understand pretty well why tests have failed - does it have any relationship with my change? |
Author
|
I've found just some warnings about configuration file deprecated sections in Travis CI report - I don't think that it can be caused by me. |
| public function afterCompile(Nette\PhpGenerator\ClassType $class) | ||
| { | ||
| $meta = $class->properties['meta']; | ||
| $meta = $class->getProperties()['meta']; |
Contributor
There was a problem hiding this comment.
$class->getProperty('meta');Isn't this better??
Author
There was a problem hiding this comment.
You are right, that's better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to $class->getProperties() to avoid "User Deprecated: Missing annotation @Property for Nette\PhpGenerator\ClassType::$properties" exception.
