Open
Conversation
ERR_HTTP_TRAILER_INVALID
itsmrshow
reviewed
Oct 19, 2022
itsmrshow
left a comment
itsmrshow
left a comment
There was a problem hiding this comment.
Tested these changes, it stops the WebSocket from breaking on a failed header overwrite.
|
This commit just makes sense. Otherwise the request just stops all activity. |
Owner
|
@itsmrshow any thoughts on why this might be happening and how to reproduce? |
Contributor
|
@itsmrshow @cooye Is there any full stack trace or such for this? I agree that it might be better to understand the issues instead using a "meta try-catch" to catch anything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ERR_HTTP_TRAILER_INVALID