Conversation
Member
|
I don't think the eivenvalue decomposition is wrong, just potentially expensive and, as a result, surprising to users. |
Member
Author
|
The alternative here is that we're going to error. I don't know if people solve problems with super large Q matrices? And need to use this bridge, and worry about performance? |
Member
Author
|
The suggestion from #1971 is to add LDLFactorizations as a package extension. |
blegat
reviewed
Jan 30, 2026
| # triangular, but nothing says that it has to be. | ||
| E = LinearAlgebra.eigen(LinearAlgebra.Symmetric(Matrix(Q))) | ||
| if !all(isreal, E.values) || minimum(E.values) < 0 | ||
| error("Matrix is not PSD") |
Member
There was a problem hiding this comment.
Maybe give the minimal eigenvalue
Member
|
Using eigenvalues as a fallback sounds like a good idea, maybe we should allow a small tolerance. Historically, we have allowed MathOptInterface.jl/src/Bridges/Constraint/bridges/SquareBridge.jl Lines 110 to 123 in 05cb226 We can use a very tight tolerance and only loosen it upon request. Maybe starting with 0 is good but it should be easy to find example of reasonable PSD matrices having negative eigenvalues like -1e-15
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1971
There aren't many good options here.
My trivial test case is
(x + y)^2 / 2.The permissive options all fail:
LDLFactorizations.jl works:
but it requires us to add a GPL dependency.
This PR implements an option I don't think we've previously considered: do something that isn't upper triangular...
Am I missing something obviously wrong?