⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Reorder logging levels #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
b4nst wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reorder logging levels #97

b4nst wants to merge 2 commits into from

Conversation

@b4nst
Copy link

@b4nst b4nst commented Sep 11, 2019

Fixes #96

anru
anru reviewed Dec 12, 2019
View reviewed changes
src/types.js
color: 'blue',
label: 'waiting',
logLevel: 'info'
logLevel: 'debug'
Copy link

@anru anru Dec 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about these changes ?
Looks like info, fav, sucess and other types should use info level by default

Copy link
Author

@b4nst b4nst Dec 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused here. Obviously you're right this should be info. It makes no sense that the warn is in debug, and I don't understand what the hell this changes are.

https://github.com/klaussinani/signale/blame/395c3457e3b166bb3e484994eeae7efcbfcefd69/src/types.js

Here I can see the changes that I recall committing: info, and success are at info level (fav is in debug though, but I recall making this change). So am I too tired to see what is going on here, or is it the github pr view which is broken ?

@anru
Copy link

anru commented Apr 8, 2020

I have added PR #105 which have similar changes but also having corresponding changes in readme

@klaudiosinani klaudiosinani added the enhancement New feature or request label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@anru anru anru left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reorder logging levels to reduce debug noise

3 participants

@b4nst @anru @klaudiosinani