Bump max inflight HTLC value for outbound private channels#303
Merged
tnull merged 2 commits intolightningdevkit:mainfrom Jun 14, 2024
Merged
Conversation
tnull
force-pushed
the
2024-05-bump-max-inflight-for-outbound-private-channels
branch
2 times, most recently
from
17a41e8 to
bbeead2
Compare
Collaborator
Author
|
Rebased on main after #141 landed. |
.. now only via `Config::default_user_config`
.. as users are confused why they can't send the full channel amount. LDK will default to this behavior soon, anyways, at which point we'll be able to drop this manual override again.
tnull
force-pushed
the
2024-05-bump-max-inflight-for-outbound-private-channels
branch
from
bbeead2 to
dc5d00e
Compare
Collaborator
Author
|
Rebased to resolve minor conflicts after #307 landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #141.
Firstly, we consolidate setting the default values of
UserConfig.Secondly, we override
max_inbound_htlc_value_in_flight_percent_of_channelfor private outbound channels to be 100% as users keep beeing confused why they aren't able to send the full channel value. LDK will likely default to this behavior soon anyways, at which point we'll be able to drop this manual override again.