Have Builder::set_entropy_seed_bytes take [u8; 64] for non-uniffi#493
Merged
tnull merged 1 commit intolightningdevkit:mainfrom Mar 19, 2025
Merged
Conversation
Historically, we aligned `uniffi` and non-`uniffi` APIs as much as possible (mostly because there are no rendered docs available for the latter). As the APIs have diverged a bit by now anyways, we here have `Builder::set_entropy_seed_bytes` take a `[u8; 64]`, which makes for a better API in Rust.
tnull
force-pushed
the
2025-03-take-bytes-by-array
branch
from
96b5f68 to
7cf9ef9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #489.
Historically, we aligned
uniffiand non-uniffiAPIs as much as possible (mostly because there are no rendered docs available for the latter). As the APIs have diverged a bit by now anyways, we here haveBuilder::set_entropy_seed_bytestake a[u8; 64], which makes for a better API in Rust.