Add explicit type definition for ChannelDetails

[chuksys]

This change uses an alias (LdkChannelDetails) and an explicit Vec<LdkChannelDetails> type annotation for open_channels in close_channel_internal and update_channel_config. This resolves type ambiguity caused by a name collision with the local ChannelDetails struct, which prevents rust-analyzer from correctly inferring the type as Vec, leading to an incorrect len() is private error.

This is a minor fix that would improve the development experience.

[ldk-reviews-bot]

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[tnull]

Hmm, can't this be fixed on the rust-analyzer side of things? Not a big fan of making changes just for tooling, especially given that every contributor might run slightly different setups.

[chuksys]

I totally get not wanting to fix things just for tooling.

I think rust-analyzer struggling to infer the correct type likely means we might want to make the code clearer here by using an explicit alias so that it's easy for anyone to know that what is returned here is a Vec of ChannelDetails from LDK and not the local wrapper.

Also I think that since rust-analyzer is a relatively popular tool (over 5 million installs), this small change gives us better readability in addition to the significant developer experience gain!

Let me know if that makes sense - would be happy to hold-off on this if otherwise.

[tnull]

I think rust-analyzer struggling to infer the correct type likely means we might want to make the code clearer here by using an explicit alias so that it's easy for anyone to know that what is returned here is a Vec of ChannelDetails from LDK and not the local wrapper.

Yeah, I don't buy there is any real confusion here. But anyways, if it improves things for you, there is no real harm here. I just know other people don't like to have such additional clutter in the code. But, until they complain, we can go ahead and merge this for now.

[chuksys]

Thank you!