Update docs for ChannelDetails fields which change on splice#4250
Conversation
Various fields in `ChannelDetails` refer to channel information which changes on splice, which we ensure is consistently documented here.
|
👋 Thanks for assigning @benthecarman as a reviewer! |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4250 +/- ##
=======================================
Coverage 89.32% 89.32%
=======================================
Files 180 180
Lines 138730 138730
Branches 138730 138730
=======================================
+ Hits 123914 123922 +8
+ Misses 12190 12184 -6
+ Partials 2626 2624 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Now adopted for LDK Node's variant of |
|
Backported in #4254 |
Various fields in
ChannelDetailsrefer to channel information which changes on splice, which we ensure is consistently documented here.