[0.2] Backports and cut 0.2.1

[TheBlueMatt]

Backport of #4341, #4259 (which is really a behavior change not a strict bugfix so open to pushback on including it), #4262, #4268, #4274, #4312, #4342

[ldk-reviews-bot]

👋 Thanks for assigning @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[codecov]

Codecov Report

❌ Patch coverage is 88.80597% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.11%. Comparing base (0c8269b) to head (45a9d2b).
⚠️ Report is 14 commits behind head on 0.2.

Files with missing lines	Patch %	Lines
lightning/src/ln/outbound_payment.rs	84.96%	12 Missing and 8 partials ⚠️
lightning/src/ln/channelmanager.rs	83.78%	6 Missing ⚠️
lightning/src/ln/functional_test_utils.rs	33.33%	2 Missing ⚠️
lightning-background-processor/src/lib.rs	90.00%	1 Missing ⚠️
lightning/src/ln/onion_utils.rs	98.30%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              0.2    #4344      +/-   ##
==========================================
- Coverage   88.87%   86.11%   -2.77%     
==========================================
  Files         180      156      -24     
  Lines      138117    99889   -38228     
  Branches   138117    99889   -38228     
==========================================
- Hits       122752    86018   -36734     
+ Misses      12543    11378    -1165     
+ Partials     2822     2493     -329     

Flag	Coverage Δ
fuzzing	?
tests	86.11% <88.80%> (-2.61%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[valentinewallace]

Looks good modulo #4342 needs review (and the PR description needs updating to include it)

[ldk-reviews-bot]

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

[TheBlueMatt]

Updated to the merged version of #4342 this should be ready to go.

[ldk-reviews-bot]

✅ Added second reviewer: @jkczyz

[TheBlueMatt]

Oops forgot to fix the silent conflicts again.

$ git diff-tree -U3 abf5c10716 45a9d2be65
diff --git a/lightning/src/ln/channelmanager.rs b/lightning/src/ln/channelmanager.rs
index 3a0f61ccad..02bb67e15c 100644
--- a/lightning/src/ln/channelmanager.rs
+++ b/lightning/src/ln/channelmanager.rs
@@ -5549,6 +5549,7 @@ where
 	) -> Result<(), Bolt11PaymentError> {
 		let best_block_height = self.best_block.read().unwrap().height;
 		let _persistence_guard = PersistenceNotifierGuard::notify_on_drop(self);
+		let payment_hash = PaymentHash(invoice.payment_hash().to_byte_array());
 		self.pending_outbound_payments.pay_for_bolt11_invoice(
 			invoice,
 			payment_id,
@@ -5563,7 +5564,7 @@ where
 			best_block_height,
 			&self.pending_events,
 			|args| self.send_payment_along_path(args),
-			&WithContext::from(&self.logger, None, None, Some(invoice.payment_hash())),
+			&WithContext::from(&self.logger, None, None, Some(payment_hash)),
 		)
 	}

@@ -17583,6 +17584,7 @@ where
 										true,
 										&mut compl_action,
 										&pending_events,
+										&logger,
 									);
 									// If the completion action was not consumed, then there was no
 									// payment to claim, and we need to tell the `ChannelMonitor`