⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@elnosh
Copy link
Contributor

@elnosh elnosh commented Jan 27, 2026

Closes #4337

Changes negotiate_anchors_zero_fee_htlc_tx default to true and removes the manually_accept_inbound_channels config option.

Edit: Left the tests with default to non-anchor

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jan 27, 2026

👋 Thanks for assigning @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@TheBlueMatt
Copy link
Collaborator

Changing the negotiate_anchors_zero_fee_htlc_tx default to true in the tests causes +100 test failures

Hmm, can you ask claude to change those to use the test_default_config() thing? Our test config default has diverged somewhat from our actual default config for reasons like this but that's okay...

Removes the `manually_accept_inbound_channels` config
option. In upcoming commit we will default to anchor
channels which requires users checking if they have
enough onchain funds to cover fees in case of a force
close. Hence, we move to always require users to
manually accept inbound channels.
@elnosh elnosh force-pushed the manual-channel-acceptance branch from 86d25a2 to ef441ac Compare January 28, 2026 20:22
Set `negotiate_anchors_zero_fee_htlc_tx` default
to true.
@elnosh elnosh force-pushed the manual-channel-acceptance branch from ef441ac to b1ee9e3 Compare January 28, 2026 20:38
@elnosh elnosh marked this pull request as ready for review January 28, 2026 20:38
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 81.39535% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.09%. Comparing base (7fe3268) to head (b1ee9e3).

Files with missing lines Patch % Lines
lightning/src/ln/channelmanager.rs 70.45% 12 Missing and 1 partial ⚠️
lightning/src/ln/functional_test_utils.rs 90.62% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main    #4354       +/-   ##
=========================================
+ Coverage      0   86.09%   +86.09%     
=========================================
  Files         0      156      +156     
  Lines         0   102450   +102450     
  Branches      0   102450   +102450     
=========================================
+ Hits          0    88202    +88202     
- Misses        0    11754    +11754     
- Partials      0     2494     +2494     
Flag Coverage Δ
tests 86.09% <81.39%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jkczyz jkczyz requested a review from wpaulino January 29, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move to always-manually-accepting channels (and default anchors)

3 participants