Add a module to authenticate by proving private key knowledge#54
Merged
tankyleo merged 1 commit intolightningdevkit:mainfrom Jan 17, 2026
Merged
Add a module to authenticate by proving private key knowledge#54tankyleo merged 1 commit intolightningdevkit:mainfrom
tankyleo merged 1 commit intolightningdevkit:mainfrom
Conversation
|
I've assigned @tankyleo as a reviewer! |
This adds an authentication module to match the service side logic at lightningdevkit/vss-server#79
tnull
approved these changes
Jan 15, 2026
Contributor
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
LGTM, I'll refrain from merging to give Leo a chance to take a look first, too.
tankyleo
reviewed
Jan 17, 2026
Comment on lines
+60
to
+61
| /// In addition to the automatically-added `Authentication` header, any headers provided in | ||
| /// `default_headers` (except an `Authentication` header) will be added to the headers list. |
Contributor
There was a problem hiding this comment.
Shouldn't this be the Authorization header ?
Contributor
|
Post merge ACK, see PR below for switch to "Authorization": |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an authentication module to match the service side logic at lightningdevkit/vss-server#79