Relax validation on the postgres service address setting#91
Open
tankyleo wants to merge 1 commit intolightningdevkit:mainfrom
Open
Relax validation on the postgres service address setting#91tankyleo wants to merge 1 commit intolightningdevkit:mainfrom
tankyleo wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
Contributor
tankyleo
commented
Feb 4, 2026
tankyleo
commented
We previously parsed the postgres service address setting into a `std::net::SocketAddr`, which was overly restrictive, and prevented the use of hostnames for that setting. The postgres service address is logged on startup, so the user can check that the service address is correctly configured in case of a failure to connect to the postgres database on startup.
|
👋 I see @joostjager was un-assigned. |
tsmith123
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.