⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@bnussman-akamai
Copy link
Member

Description 📝

  • Adds extra conditional logic to the Linode Details page to ensure the new "Maintenance Policy" value only shows when the Linode actually supports it
  • Updates api-v4 types to reflect the API

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

Before After
Screenshot 2026-01-12 at 11 26 18 AM Screenshot 2026-01-12 at 11 31 46 AM
A maintenance policy is showing even though this Linode does not have one Now, no maintenance policy will show because the Linode does not have one

How to test 🧪

  • Have a Linode on your account that a maintenance_policy of null and does not have Maintenance Policy in the capabilities array
    • I used Chrome's "Override Content" feature to mock this
  • Verify the Maintenance Policy section does not show beside the Linode's status
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verification steps ✅
Code review ✅
LinodeEntityDetail unit test passes locally & in CI ✅

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 855 passing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing855 Passing11 Skipped42m 5s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

4 participants