You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @nanitsuku@tkgdsg ,
this patchset can not be merged in this way.
You started with an initial patch which introduces lots of changes (e.g. also indention and wrong whitespace changes or the changes in state_bcm.c) which are then fixed in the follow up commits. This is not how pull requests are intended.
E.g. the patch "support canfd for can raw" reverts the changes to state_bcm.c
And the "< fdframe" command still handles only 8 bytes.
Do you plan to support the BCM functionality?
In general please try to provide several step-by-step commits that can be easily reviewed and understood.
E.g.
convert to use struct canfd_frame
figure out the interface capabilities
convert the protocol flavors like state_raw and state_bcm
other changes
documentation
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CANFD support
I've added new fd dedicated frame for state_raw.
Could I get your opinion on whether this implementation method is correct?