⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@cloudwebrtc
Copy link
Contributor

@cloudwebrtc cloudwebrtc commented Jan 19, 2026

close #355

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted track mute behavior so the platform-specific condition now targets only Firefox on web.
    • Fixed Windows behavior to ensure the camera stops after a video track is unpublished.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

The skipStopForTrackMute function in lib/src/support/platform.dart was simplified: it no longer returns true for Windows. It now returns true only for web platforms when the browser is Firefox. A patch file documenting stopping the camera after unpublish on Windows was added.

Changes

Cohort / File(s) Summary
Platform utility fix
lib/src/support/platform.dart
Simplified skipStopForTrackMute by removing the Windows-specific condition; now returns true only for web + Firefox.
Windows camera patch note
.changes/windows-stop-camera-after-unpublish
Added patch entry noting camera should be stopped after unpublishing a video track on Windows.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped in code and gave a tweak,
Windows cameras now sleep when you speak.
Firefox on web still gets a pass,
Quiet devices across the grass. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: stopping the camera after unpublishing a video track on Windows, which aligns with the primary objective of fixing issue #355.
Linked Issues check ✅ Passed The code changes implement the required fix for issue #355 by removing the Windows-specific condition from skipStopForTrackMute and adding platform-specific handling to stop the camera after unpublishing.
Out of Scope Changes check ✅ Passed Both changes (the skipStopForTrackMute update and the changelog entry) are directly related to fixing the Windows camera issue described in issue #355; no out-of-scope changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d36a60f and adf79e1.

📒 Files selected for processing (1)
  • .changes/windows-stop-camera-after-unpublish
✅ Files skipped from review due to trivial changes (1)
  • .changes/windows-stop-camera-after-unpublish
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Build for Flutter Web
  • GitHub Check: Build for Flutter iOS
  • GitHub Check: Build for Flutter Linux
  • GitHub Check: Build for Flutter macOS
  • GitHub Check: Build for Flutter Android
  • GitHub Check: Build for Flutter Windows
  • GitHub Check: Build for Flutter Web WASM

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudwebrtc cloudwebrtc changed the title fix: stop camera after stop publishing video track(windows)`. fix: stop camera after stop publishing video track(windows). Jan 19, 2026
@hiroshihorie hiroshihorie merged commit 2e421d4 into main Jan 27, 2026
17 checks passed
@hiroshihorie hiroshihorie deleted the duan/fix-issue-355 branch January 27, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Camera not turned off in Windows after stop publishing video track

3 participants