Change random sort to use Fisher-Yates shuffle#424
Open
d8uv wants to merge 1 commit intomalsup:masterfrom
Open
Change random sort to use Fisher-Yates shuffle#424d8uv wants to merge 1 commit intomalsup:masterfrom
d8uv wants to merge 1 commit intomalsup:masterfrom
Conversation
Contributor
|
+1. http://phrogz.net/JS/JavaScript_Random_Array_Sort.html Interestingly, different browsers have very different biases, but in all browsers the weightings are dramatically unequal. A performance-optimized modified Fisher-Yates shuffle algorithm that uses a |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting by Math.random() doesn't give you a fast or a consistent shuffle. With that said, this shuffle is still bigger and more complicated than the naive approach, and I haven't done any formal benchmarking or testing. I leave it completely to you.