Add support for Angular 1.5 components#163
Open
benelliott wants to merge 4 commits intomarcoslin:masterfrom
Open
Add support for Angular 1.5 components#163benelliott wants to merge 4 commits intomarcoslin:masterfrom
benelliott wants to merge 4 commits intomarcoslin:masterfrom
Conversation
…gularAMD into feature/components # Conflicts: # src/angularAMD.js
Owner
|
@benelliott thanks for the pull request. Did you happen to had a chance to look at Travis errors? |
|
So components does not work with latest version 0.2.1 of angularAMD? |
Collaborator
Author
|
Hi @marcoslin @andidev , sorry for not looking into this further - I was having trouble getting angularAMD off the ground with a 1.5-component-heavy app and assumed that it was simply missing an alias for "component" but never got round to checking out the Travis errors. |
Collaborator
Author
|
Just looking at the trace now - strangely, Travis seems to be erroring on the minified version of the lib even though I actually forgot to rebuild it (so it should be the same as master!). Is there any way to check that the current master branch actually passes the tests? |
|
+1 |
1 similar comment
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the new "component" syntactic sugar introduced in Angular 1.5.