-
Notifications
You must be signed in to change notification settings - Fork 16
Fix filemanager mouse click #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
JoeKar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work as intended.
We should update the version number and add a new version entry to:
repo.json#L42
Co-authored-by: Jöran Karl <3951388+JoeKar@users.noreply.github.com>
JoeKar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update the version number and add a new version entry to:
repo.json#L42
Realized, that the whole binary/archive handling of different plugins within one updated-plugins repository is crap. We can't simply tag one plugin and use GitHubs automatism to create archives of this one tag, which we can simply link in the repo.json.
Right now every plugin must be archived/zipped and uploaded manually to the assets of the v1.0.0 release.
Long story short:
We should extract every of the updated plugins into its own repository within the micro-editor organization. This makes the single plugin handling much easier.
@dmaluka:
Besides of that do you have any complaints to this PR?
|
Instead of calling directly try_open_at_y(tree_view.Cursor.Loc.Y) in both Tab and mouse click, I added a call to try_open_at_cursor. This function was was unsused and mentioned in the README. I had to remove the 2nd condition of the "if" bc otherwise clicking on ".." in empty directories will not work. |
Mouse click was broken:
Fixes #25
Closes micro-editor/micro#3951